pmh_only/bp-check
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix KeyError if rotation attributes don't exist

Browse Source
This commit is contained in:
skyuecx0630 2024-08-07 16:45:49 +09:00
parent 746c6a98df
commit d00a457ae0
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
services/secrets_manager.py
View File

@ -13,7 +13,7 @@ def secretsmanager_rotation_enabled_check():
secrets = client.list_secrets()["SecretList"] secrets = client.list_secrets()["SecretList"]
for secret in secrets: for secret in secrets:
if secret["RotationEnabled"] == True: if secret.get("RotationEnabled") == True:
compliant_resources.append(secret["ARN"]) compliant_resources.append(secret["ARN"])
else: else:
non_compliant_resources.append(secret["ARN"]) non_compliant_resources.append(secret["ARN"])
@ -31,7 +31,11 @@ def secretsmanager_scheduled_rotation_success_check():
secrets = client.list_secrets()["SecretList"] secrets = client.list_secrets()["SecretList"]
for secret in secrets: for secret in secrets:
if secret["RotationEnabled"] == True: if secret.get("RotationEnabled") == True:
if 'LastRotatedDate' not in secret:
non_compliant_resources.append(secret["ARN"])
continue
now = datetime.datetime.now(tz=tzlocal()) now = datetime.datetime.now(tz=tzlocal())
rotation_period = datetime.timedelta( rotation_period = datetime.timedelta(
days=secret["RotationRules"]["AutomaticallyAfterDays"] + 2 days=secret["RotationRules"]["AutomaticallyAfterDays"] + 2
@ -56,7 +60,11 @@ def secretsmanager_secret_periodic_rotation():
secrets = client.list_secrets()["SecretList"] secrets = client.list_secrets()["SecretList"]
for secret in secrets: for secret in secrets:
if secret["RotationEnabled"] == True: if secret.get("RotationEnabled") == True:
if 'LastRotatedDate' not in secret:
non_compliant_resources.append(secret["ARN"])
continue
now = datetime.datetime.now(tz=tzlocal()) now = datetime.datetime.now(tz=tzlocal())
elapsed_time_after_rotation = now - secret["LastRotatedDate"] elapsed_time_after_rotation = now - secret["LastRotatedDate"]